Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy] OP_interp#17793

Merged
haojin2 merged 4 commits intoapache:masterfrom
Tommliu:interp
Apr 8, 2020
Merged

[Numpy] OP_interp#17793
haojin2 merged 4 commits intoapache:masterfrom
Tommliu:interp

Conversation

@Tommliu
Copy link
Copy Markdown
Contributor

@Tommliu Tommliu commented Mar 9, 2020 •
edited
Loading

Description

implementation of Numpy compatible operator interp

Numpy Operator Old FFI (ctypes) (us) New FFI (cython) (us)
interp 149.24 109.11

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@Tommliu Tommliu requested a review from szha as a code owner March 9, 2020 13:30
@haojin2 haojin2 added the Numpy label Mar 9, 2020
@haojin2 haojin2 self-assigned this Mar 9, 2020
haojin2
haojin2 reviewed Mar 9, 2020
View reviewed changes
Comment thread tests/python/unittest/test_numpy_op.py Outdated
haojin2
haojin2 reviewed Mar 9, 2020
View reviewed changes
Comment thread src/operator/numpy/np_interp_op-inl.h Outdated
haojin2
haojin2 reviewed Mar 9, 2020
View reviewed changes
Comment thread src/operator/numpy/np_interp_op-inl.h
@haojin2
Copy link
Copy Markdown
Contributor

haojin2 commented Mar 9, 2020

Also address the sanity errors.

haojin2
haojin2 approved these changes Mar 10, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hzfan
hzfan reviewed Mar 11, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@hzfan hzfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/api/operator/numpy/np_interp_op.cc Outdated
Comment thread src/api/operator/numpy/np_interp_op.cc Outdated
@Tommliu Tommliu force-pushed the interp branch 2 times, most recently from becbee5 to 641c1e2 Compare March 13, 2020 02:28
haojin2
haojin2 reviewed Mar 13, 2020
View reviewed changes
Comment thread src/operator/numpy/np_interp_op-inl.h Outdated
haojin2
haojin2 reviewed Mar 13, 2020
View reviewed changes
Comment thread src/operator/numpy/np_interp_op-inl.h Outdated
@Tommliu Tommliu force-pushed the interp branch 2 times, most recently from 009e538 to 61034f8 Compare March 18, 2020 00:14
@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Mar 25, 2020

None of the jobs entered are supported.
Jobs entered by user: [ci/jenkins/mxnet-validation/centos-gpu, ci/jenkins/mxnet-validation/unix-cpu, ci/jenkins/mxnet-validation/windows-gpu]
CI supported Jobs: [clang, unix-cpu, sanity, edge, miscellaneous, windows-gpu, windows-cpu, unix-gpu, website, centos-gpu, centos-cpu]

@Tommliu
Copy link
Copy Markdown
Contributor Author

Tommliu commented Mar 25, 2020

@mxnet-bot run ci [centos-gpu, unix-cpu, windows-gpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Mar 25, 2020

Jenkins CI successfully triggered : [centos-gpu, windows-gpu, unix-cpu]

@Tommliu
Copy link
Copy Markdown
Contributor Author

Tommliu commented Mar 25, 2020

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Mar 25, 2020

Jenkins CI successfully triggered : [windows-gpu]

2 similar comments
@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Mar 25, 2020

Jenkins CI successfully triggered : [windows-gpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Mar 26, 2020

Jenkins CI successfully triggered : [windows-gpu]

@Tommliu
Copy link
Copy Markdown
Contributor Author

Tommliu commented Apr 7, 2020

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Apr 7, 2020

Jenkins CI successfully triggered : [windows-gpu]

@haojin2 haojin2 merged commit 178b98e into apache:master Apr 8, 2020
sxjscience pushed a commit to sxjscience/mxnet that referenced this pull request Jul 1, 2020
@Tommliu @sxjscience
[Numpy] OP_interp (apache#17793)
2f69252 
* interp

* fix_uninitialized_issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@szha szha Awaiting requested review from szha szha is a code owner

2 more reviewers

@haojin2 haojin2 haojin2 approved these changes

@hzfan hzfan hzfan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@haojin2 haojin2

Labels

Numpy

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Tommliu @haojin2 @mxnet-bot @hzfan