This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[Numpy] FFI for cumsum and add#17747
Merged
haojin2 merged 5 commits intoapache:masterfrom Mar 5, 2020
Merged
Conversation
szha
reviewed
Mar 3, 2020
| OBJECT_HANDLE = 7 | ||
| STR = 8 | ||
| BYTES = 9 | ||
| PYARG = 10 |
Contributor
Author
There was a problem hiding this comment.
Basically it designates a python argument to be returned. For example, PythonArg(2) says the 2nd python argument should be returned.
It is introduced for out. If parameter out is not None, then out should serve as the return value. Note that we should not return the NDArray* specified by out, as it creates another NDArrayBase in frontend, and thus one NDArray* in backend gets destructed twice by two frontend NDArrayBase
MoisesHer
pushed a commit
to MoisesHer/incubator-mxnet
that referenced
this pull request
Apr 10, 2020
* FFI cumsum * Dispatch ufunc * Add PythonArg * Remove unused data type * Seperate op_utils and utils
anirudh2290
pushed a commit
to anirudh2290/mxnet
that referenced
this pull request
May 29, 2020
* FFI cumsum * Dispatch ufunc * Add PythonArg * Remove unused data type * Seperate op_utils and utils
sxjscience
pushed a commit
to sxjscience/mxnet
that referenced
this pull request
Jul 1, 2020
* FFI cumsum * Dispatch ufunc * Add PythonArg * Remove unused data type * Seperate op_utils and utils
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use new ffi for cumsum and add for better speed. Also two changes to the new ffi infra:
outfor new ffi.addChecklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments
@haojin2 @reminisce