Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[NumPy] Add NumPy support for triu#17614

Merged
haojin2 merged 23 commits intoapache:masterfrom
vexilligera:triu
Apr 14, 2020
Merged

[NumPy] Add NumPy support for triu#17614
haojin2 merged 23 commits intoapache:masterfrom
vexilligera:triu

Conversation

@vexilligera
Copy link
Copy Markdown
Contributor

@vexilligera vexilligera commented Feb 17, 2020

Description

This is directly modified from np.tril

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@vexilligera vexilligera requested a review from szha as a code owner February 17, 2020 08:53
@haojin2 haojin2 self-assigned this Feb 17, 2020
@haojin2 haojin2 added the Numpy label Feb 17, 2020
haojin2
haojin2 approved these changes Feb 20, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will re-trigger the CI builds to make this pass.

haojin2
haojin2 approved these changes Mar 12, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @hzfan Can you take a second look specifically on the ffi part?

hzfan
hzfan reviewed Mar 17, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@hzfan hzfan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haojin2 LGTM, with some hints about the clang-tidy error.

Comment thread src/api/operator/numpy/np_triu_op.cc Outdated
@haojin2
Copy link
Copy Markdown
Contributor

haojin2 commented Apr 13, 2020

@mxnet-bot run ci [all]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Apr 13, 2020

Jenkins CI successfully triggered : [website, windows-gpu, edge, clang, sanity, unix-cpu, centos-gpu, miscellaneous, unix-gpu, windows-cpu, centos-cpu]

@vexilligera
Copy link
Copy Markdown
Contributor Author

vexilligera commented Apr 14, 2020

@mxnet-bot run ci [all]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Apr 14, 2020

Jenkins CI successfully triggered : [website, sanity, miscellaneous, clang, windows-cpu, centos-gpu, centos-cpu, unix-cpu, windows-gpu, edge, unix-gpu]

@vexilligera
Copy link
Copy Markdown
Contributor Author

vexilligera commented Apr 14, 2020

@mxnet-bot run ci [centos-cpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Apr 14, 2020

Jenkins CI successfully triggered : [centos-cpu]

@vexilligera
Copy link
Copy Markdown
Contributor Author

vexilligera commented Apr 14, 2020

@mxnet-bot run ci [centos-cpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Apr 14, 2020

Jenkins CI successfully triggered : [centos-cpu]

@haojin2 haojin2 merged commit c7d2b3c into apache:master Apr 14, 2020
sxjscience pushed a commit to sxjscience/mxnet that referenced this pull request Jul 1, 2020
@vexilligera @haojin2 @sxjscience
[NumPy] Add NumPy support for triu (apache#17614)
5ba7a77 
* triu

* rebase

* fix ci

* merge

* triu new ffi

* cpplint

* cpplint

* ffi benchmark

* fix style

* merge

* fix conflict

Co-authored-by: Ubuntu <ubuntu@ip-172-31-8-137.us-east-2.compute.internal>
Co-authored-by: Hao Jin <hjjn.amzn@gmail.com>
AntiZpvoh pushed a commit to AntiZpvoh/incubator-mxnet that referenced this pull request Jul 6, 2020
@vexilligera @haojin2 @AntiZpvoh
[NumPy] Add NumPy support for triu (apache#17614)
a816ad2 
* triu

* rebase

* fix ci

* merge

* triu new ffi

* cpplint

* cpplint

* ffi benchmark

* fix style

* merge

* fix conflict

Co-authored-by: Ubuntu <ubuntu@ip-172-31-8-137.us-east-2.compute.internal>
Co-authored-by: Hao Jin <hjjn.amzn@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@szha szha Awaiting requested review from szha szha is a code owner

2 more reviewers

@hzfan hzfan hzfan left review comments

@haojin2 haojin2 haojin2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@haojin2 haojin2

Labels

Numpy

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vexilligera @haojin2 @mxnet-bot @hzfan