This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Fix storage type infer of softmax backward#17576
Merged
leezu merged 2 commits intoapache:masterfrom Feb 15, 2020
Merged
Conversation
Member
Author
|
@eric-haibin-lin Could you please try it out? I cannot create a simple case to reproduce the error. |
Contributor
|
@TaoLv could you next time revert the buggy commit? I spent some time today to track down the bug, which could have been avoided. |
1 task
Member
Author
|
@leeze, Got it. Thank you for the merging. |
zheyuye
pushed a commit
to zheyuye/incubator-mxnet
that referenced
this pull request
Feb 19, 2020
* fix storage type of softmax backward * remove unused variable
anirudh2290
pushed a commit
to anirudh2290/mxnet
that referenced
this pull request
May 29, 2020
* fix storage type of softmax backward * remove unused variable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue introduced by #17170 , which causes below error when fine-tuning a bert model with latest gluonnlp and mxnet-mkl.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments