This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Pseudo 2D transpose kernel#16229
Merged
Merged
Conversation
Member
|
@sxjscience FYI @dtracz Could you look into the CI failures? |
ptrendx
reviewed
Sep 23, 2019
sxjscience
reviewed
Oct 11, 2019
aaronmarkham
pushed a commit
to aaronmarkham/incubator-mxnet
that referenced
this pull request
Oct 16, 2019
* add kernel * pseudo2dtranspose test * better calculating grid & block * add checking max sizes * test of transpose not fitting in the cuda grid * support for large tensors * estetic fixes * change iterated dimension * fix Windows issue * chane types to intex_t * fix build error
Contributor
|
@access2rohit GPU pseudo 2d transpose |
ChaiBapchya
reviewed
Oct 17, 2019
| z = mx.nd.transpose(y, axes=axes) | ||
| assert_allclose(x_np, z.asnumpy().astype('uint8')) | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
@sxjscience this removes with_seed() from existing function. Should have been caught...
Member
There was a problem hiding this comment.
Oops, you are right, could you make a PR to fix it?
Member
There was a problem hiding this comment.
@ChaiBapchya Sorry, my bad. I should have caught this. Needs to be more careful next time.
Contributor
There was a problem hiding this comment.
Oops, you are right, could you make a PR to fix it?
Yes fixing it in 1 of my PRs.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fast pseudo-2D transpose kernel.
Supports only transposes that satisfy:
Exists n and m such that:
params = (0, ..., n-1, n+m, ..., params.size, n, ..., n+m-1)
Example: (0, 2, 3, 1) or (0, 3, 1, 2), but not (0, 2, 1, 3).