Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

fix slice operator for following inputs: (1) begin=end and (2) end=-1, step=-1#14230

Closed
mseth10 wants to merge 4 commits intoapache:masterfrom
mseth10:fix-issue-13760-14105
Closed

fix slice operator for following inputs: (1) begin=end and (2) end=-1, step=-1#14230
mseth10 wants to merge 4 commits intoapache:masterfrom
mseth10:fix-issue-13760-14105

Conversation

@mseth10
Copy link
Copy Markdown
Contributor

@mseth10 mseth10 commented Feb 22, 2019

Description

This PR fixes nd.slice for erroneous output in the following cases:
(1) begin=end ( fixes #13760 )
(2) end=-1, step=-1 ( fixes #14105 )

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mseth10 mseth10 force-pushed the fix-issue-13760-14105 branch from 9dd9b89 to 6db3b7a Compare February 22, 2019 17:44
@mseth10
Copy link
Copy Markdown
Contributor Author

mseth10 commented Feb 22, 2019

Closing this PR as it is a duplicate of #14107

@mseth10 mseth10 closed this Feb 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nd.slice errors out when end=-1 and step=-1 nd.slice does not return empty tensor when begin=end

1 participant