This repository was archived by the owner on Nov 17, 2023. It is now read-only.
fix slice operator for following inputs: (1) begin=end and (2) end=-1, step=-1#14230
Closed
mseth10 wants to merge 4 commits intoapache:masterfrom
Closed
fix slice operator for following inputs: (1) begin=end and (2) end=-1, step=-1#14230mseth10 wants to merge 4 commits intoapache:masterfrom
mseth10 wants to merge 4 commits intoapache:masterfrom
Conversation
9dd9b89 to
6db3b7a
Compare
Contributor
Author
|
Closing this PR as it is a duplicate of #14107 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes nd.slice for erroneous output in the following cases:
(1) begin=end ( fixes #13760 )
(2) end=-1, step=-1 ( fixes #14105 )
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments