This repository was archived by the owner on Nov 17, 2023. It is now read-only.
adding graceful exit for begin=end case for nd.slice#14103
Closed
mseth10 wants to merge 1 commit intoapache:masterfrom
Closed
adding graceful exit for begin=end case for nd.slice#14103mseth10 wants to merge 1 commit intoapache:masterfrom
mseth10 wants to merge 1 commit intoapache:masterfrom
Conversation
Member
|
is it better to return a 0-shape tensor when begin == end? |
Contributor
|
Could you elaborate on " All changes have test coverage:"? |
b4a0e17 to
829bed7
Compare
Contributor
Author
|
Closing this PR, and submitting it as part of another PR #14107 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
nd.slice outputs unexpectedly (throws incorrect output/ error message) when begin=end. This PR allows graceful exit for this case. This PR fixes #13760 .
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments