This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Fix generated html docs javascript error.#13240
Closed
frankfliu wants to merge 1 commit intoapache:masterfrom
Closed
Fix generated html docs javascript error.#13240frankfliu wants to merge 1 commit intoapache:masterfrom
frankfliu wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
@mxnet-label-bot add [Doc, Bug] |
Contributor
aaronmarkham
left a comment
There was a problem hiding this comment.
If this other PR goes through that fixes the js...
#13246
Will we even need to make this change?
Contributor
Author
|
With #13246, the page won't render empty any more. But this fix is still needed to keep one index target. |
Contributor
Author
|
@mxnet-label-bot add [pr-awaiting-review] |
aaronmarkham
approved these changes
Nov 13, 2018
Contributor
|
Please double check... This is blank: http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-13240/1/api/python/io/io.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extra :noindex causes javascript error in html pages, which renders an empty page.
Remove extra :noidex in the model_zoo.md and io.md file.
Verified output html pages are working fine locally.
Build output can be found:
http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-13240/1/api/python/index.html#io-api
http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-13240/1/api/python/gluon/model_zoo.html
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.