This repository was archived by the owner on Nov 17, 2023. It is now read-only.
move plugin rules to sub makefile#1259
Merged
piiswrong merged 2 commits intoapache:masterfrom Jan 13, 2016
Merged
Conversation
Member
|
see #1251 we will do this like this way, which is cleaner |
Contributor
There was a problem hiding this comment.
We'd better remove or comment include plugin/*/*.mk because there will be other plugin mk rules
Contributor
Author
There was a problem hiding this comment.
I did this on purpose so that people can put new dependency in plugin folder and have them included without changing main Makefile.
This makes it possible to maintain plugins separately without touching mxnet main repo
Contributor
Author
There was a problem hiding this comment.
Ok I saw your MXNET_PLUGINS flag in sframe PR.
I'll wait for it to be merged and then rebase.
piiswrong
force-pushed
the
torch
branch
3 times, most recently
from
7ca3af5 to
28d0f74
Compare
piiswrong
added a commit
that referenced
this pull request
Jan 13, 2016
move plugin rules to sub makefile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.