This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-696] Delete comment line that contains a Unicode character#12237
Closed
cclauss wants to merge 1 commit intoapache:masterfrom
cclauss:patch-1
Closed
[MXNET-696] Delete comment line that contains a Unicode character#12237cclauss wants to merge 1 commit intoapache:masterfrom cclauss:patch-1
cclauss wants to merge 1 commit intoapache:masterfrom
cclauss:patch-1
Conversation
Python 2 has low tolerance for Unicode characters in source files without proper encoding specified. This PR removes the comment line that contains the Unicode character Fix suggested by the discussion at #12231 (comment) Probably a better way to proceed than #12231
Contributor
|
Thank you and sorry for the revert. Please feel free to re-add the functionality you added. We just reverted the PR to ensure we are back in a state that we know is working properly. We also made some changes around python 2 and 3 and thus we wanted to rule out any errors related to these switches. It seems strange that it is necessary to remove that comment. Do you think you would be able to add a check to our linter that would detect cases like this before we encounter them during runtime? That would be SUPER helpful :) In general, thanks a lot for improving the usability of mxnet! It is very appreciated. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 2 has low tolerance for Unicode characters in source files without proper encoding specified. This PR removes the comment line that contains the Unicode character
Fix suggested by the discussion at #12231 (comment)
Probably a better way to proceed than #12231
Description
(Brief description on what this PR is about)
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments