This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Fix mistyped variable name in mxnet_predict.py.#12211
Merged
Merged
Conversation
hqucms
referenced
this pull request
Aug 16, 2018
* Fix MXPredReshape in the c_predict_api. * Add unittest for the C predict API. * Fix path in the test. * Fix for Windows. * Try again to fix for Windows. * One more try to fix test on Windows. * Try again with CI. * Try importing from mxnet first if cannot find the amalgamation lib. * Add a log message when libmxnet_predict.so is not found. * Set specific rtol and atol values. * Fix missing rtol and atol values. * Empty commit. * Try again with CI. * One more try with CI. * Retry CI.
cclauss
approved these changes
Aug 16, 2018
vandanavk
approved these changes
Aug 17, 2018
sandeep-krishnamurthy
approved these changes
Aug 17, 2018
sandeep-krishnamurthy
left a comment
There was a problem hiding this comment.
LGTM. Thanks for your contributions!
marcoabreu
added a commit
that referenced
this pull request
Aug 17, 2018
This reverts commit 38bcb88.
piyushghai
added a commit
to piyushghai/incubator-mxnet
that referenced
this pull request
Aug 17, 2018
This reverts commit 38bcb88.
XinYao1994
pushed a commit
to XinYao1994/incubator-mxnet
that referenced
this pull request
Aug 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is to fix a mistyped variable name in amalgamation/python/mxnet_predict.py introduced by #11493.
Related to #8270.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments