Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Fixed backwards compatibility checker#12181

Closed
lebeg wants to merge 1 commit into
apache:masterfrom
lebeg:fix_bcc
Closed

Fixed backwards compatibility checker#12181
lebeg wants to merge 1 commit into
apache:masterfrom
lebeg:fix_bcc

Conversation

@lebeg
Copy link
Copy Markdown
Contributor

@lebeg lebeg commented Aug 15, 2018

Description

The script was reporting missing mxnet installation.

Checklist

Essentials

  • Changes are complete

Changes

  • Fixed python and pip versions to 3

Comment thread ci/docker/runtime_functions.sh Outdated

cd /work/venv
virtualenv -p python3
source /work/venv/bin/activate
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do a virtualenv why not do pip install instead of exporting PYTHONPATH?

Also, why not relative paths?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python, python2, python3 are different now, as their corresponding pip, pip2, pip3
Maybe it would be better to make 2 different virtual env's for python2 and python3. Will try that.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we want to go for a virtual env here ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind. It was just an attempt to insure python and pip are in sync.

@lebeg lebeg force-pushed the fix_bcc branch 2 times, most recently from 981ff8c to 0d6c687 Compare August 15, 2018 18:10
version=$1
echo "Installing MXNet "$version
pip install mxnet==$version --user
pip3 install mxnet==$version --user
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this resolve the Python module not found issues we are seeing in the MBCC Train Stage on Jenkins ?

@KellenSunderland
Copy link
Copy Markdown
Contributor

Can you please indicate the testing done?

@lebeg
Copy link
Copy Markdown
Contributor Author

lebeg commented Aug 17, 2018

Closing due to #12223

@lebeg lebeg closed this Aug 17, 2018
@lebeg lebeg deleted the fix_bcc branch August 17, 2018 16:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants