This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Revert "update dmlc-core (#12129)"#12173
Closed
hcho3 wants to merge 2 commits intoapache:masterfrom
hcho3:revert-dmlc-core
Closed
Revert "update dmlc-core (#12129)"#12173hcho3 wants to merge 2 commits intoapache:masterfrom hcho3:revert-dmlc-core
hcho3 wants to merge 2 commits intoapache:masterfrom
hcho3:revert-dmlc-core
Conversation
This reverts commit 096aeb6.
haojin2
approved these changes
Aug 15, 2018
Contributor
|
@marcoabreu The build for this PR has passed but the status is not reflected on this page, can you take a look? |
This reverts commit a6ecb59.
Contributor
Author
|
Closing this now. I'll submit a new pull request where individual commits from dmlc-core are cherry-picked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reverts #12129
This is to circumvent double free memory error in #12139. The memory error has been inside CSVIter but remained undetected until a recent modification of CSVParser.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments