This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Revert "update dmlc-core for security reason"#12172
Closed
hcho3 wants to merge 15 commits intoapache:masterfrom
hcho3:revert-12129-update_dmlc_core
Closed
Revert "update dmlc-core for security reason"#12172hcho3 wants to merge 15 commits intoapache:masterfrom hcho3:revert-12129-update_dmlc_core
hcho3 wants to merge 15 commits intoapache:masterfrom
hcho3:revert-12129-update_dmlc_core
Conversation
This reverts commit f3070fb.
This reverts commit 92edca8.
This reverts commit b5a2b98.
This reverts commit a6ecb59.
This reverts commit ee8755a.
This reverts commit 95dd95c.
This reverts commit 2193819.
This reverts commit ec90f4a.
This reverts commit 0241e2c.
This reverts commit d076d10.
This reverts commit 096aeb6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #12129
This is to fix double free memory error in #12139. The memory error has been inside CSVIter but remained undetected until a recent modification of CSVParser.