Root path is undefined#11970
Conversation
root_path in build_r_docs is undefined. Since the function call is commented out, this wasn't caught. Fixing the path to avoid error in future.
|
Why are we not building the R docs/ |
|
It was commented out by default - wasn't enabled later. |
|
Actually, ran into this today on another PR I'm working on. I fixed it. I can make it a separate PR if you want something right away... otherwise it'll come in the docs build pipeline refactor I'm doing. |
|
@marcoabreu The reason, according to the comment in mxdoc.py is that the latex requirement for R is too "heavy". It seems true, because I ran out of disk space on my instance while installing the dependencies. These include: To add this into a PR, it would seem I'd need to update the CI/install/R.sh and have it load these quite large deps. WDYT about that? |
|
I used a different approach on my fix, but I can align with this one if you guys plan to get this merged quickly. BTW, this will fail upon a second run because the file will already exist... so I made further changes to fix that... plus I'm massively changing this file anyways, but my PR should overlay on top of this just fine. |
|
No need for a rush, just take your time and do it right :) About how much additional disk space are we talking here? |
|
Closing this PR - Aaron's PR #11990 takes care of this. |
Description
root_path in build_r_docs is undefined. Since the
function call is commented out, this wasn't caught. Fixing
the path to avoid error in future.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments
@aaronmarkham