This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Re-enabling randomized test_operator/test_operator_gpu.test_dot#11888
Merged
marcoabreu merged 1 commit intoapache:masterfrom Jul 25, 2018
Merged
Re-enabling randomized test_operator/test_operator_gpu.test_dot#11888marcoabreu merged 1 commit intoapache:masterfrom
marcoabreu merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
Contributor
Author
|
Problem of fixed seed tracked at #11714 |
marcoabreu
reviewed
Jul 25, 2018
| # Seed set because the test is not robust enough to operate on random data | ||
| @with_seed(1234) | ||
| # @haojin2: Getting rid of fixed seed as flakiness could not be reproduced, | ||
| # tracked at https://github.com/apache/incubator-mxnet/issues/11714 |
Contributor
There was a problem hiding this comment.
Feel free to remove that comment
Contributor
Author
There was a problem hiding this comment.
Let's still keep it here, in case if it fails on some other platforms, or we detect any regression on this operator in the future. What do you think?
marcoabreu
approved these changes
Jul 25, 2018
Contributor
Author
|
@marcoabreu Checks passed, please merge when you feel comfortable to do so. |
6 tasks
XinYao1994
pushed a commit
to XinYao1994/incubator-mxnet
that referenced
this pull request
Aug 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Getting rid of the fixed seed for test_operator/test_operator_gpu.test_dot as the flakiness cannot be reproduced.
Checklist
Essentials
Changes
Comments
Can pass more than 10000 times on both CPU & GPU: