This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-606] Fix R installation in CI#11761
Merged
Merged
Conversation
This patch fixes a regression in the R installation in CI.
Contributor
Author
Member
Contributor
|
I recently had to change my docs setup script to use the r.gpg file as well: I'm curious why it took a few days for this to surface in CI. I was thinking that since it was working there, that I should use how it fetched from the keyserver... and assumed that maybe that keyserver was somehow less flaky than the one for I don't know the tradeoffs here for local file vs keyserver. At this point, I'm happy that it works with the local file. Is there a security concern? |
XinYao1994
pushed a commit
to XinYao1994/incubator-mxnet
that referenced
this pull request
Aug 29, 2018
This patch fixes a regression in the R installation in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This patch fixes a regression in the R installation in CI.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Relates to: #11601 #11602
Comments
Without manually adding the key we're getting occasional gpg server errors (happens approx 1/10 requests). My understanding is this change was made to align with documentation. Would like to chat about the tradeoffs with @aaronmarkham and @anirudh2290, but it's important that we keep the CI stable for other MXNet developers. Is the main concern with adding the key manually that it doesn't align with documentation? Would you be alright with me updating the doc instructions (I can include updated instructions in this PR).