Upgrade from Maven 4.0.0-rc-4 to 4.0.0-rc-5.

[desruisseaux]

Replace #282 which is missing the upgrade of the maven-verify.yml file.

[slachiewicz]

Maybe simply remove the version from gha yaml?

[desruisseaux]

Maybe simply remove the version from gha yaml?

No objection, but I have no idea about how GitHub workflow works. Would GitHub action still build with the correct Maven version?

[slawekjaranowski]

Maybe simply remove the version from gha yaml?

No objection, but I have no idea about how GitHub workflow works. Would GitHub action still build with the correct Maven version?

It will used a default version defined in:
https://github.com/apache/maven-gh-actions-shared/blob/df139f38c2fefc668f46b13ff80845a98ed3ae18/.github/workflows/maven-verify.yml#L53-L57

[desruisseaux]

Thanks, I didn't knew that file. But it would mean that GitHub would start to use the latest Maven version before we have verified that the plugin is compatible with it? For example, I'm trying to upgrade the maven-jar-plugin right now and I'm observing a NullPointerException with RC-5 that I didn't observed with RC-4.

[slawekjaranowski]

Thanks, I didn't knew that file. But it would mean that GitHub would start to use the latest Maven version before we have verified that the plugin is compatible with it? For example, I'm trying to upgrade the maven-jar-plugin right now and I'm observing a NullPointerException with RC-5 that I didn't observed with RC-4.

It can happens, to consider what is easier to maintain
generally next 4.x release should be ok in most cases

[slachiewicz]

For the future we will not update maven or java versions globally but per project - to limit impact scope.
Then anyone can migrate a shared lub or plugin on their own time. And save anyone else time.