feat(setup): install/uninstall primary commands; adopt/unadopt aliases - #913
feat(setup): install/uninstall primary commands; adopt/unadopt aliases#913potiuk wants to merge 3 commits into
Conversation
|
Looking for reviews :) |
milamberspace
left a comment
milamberspace
left a comment
There was a problem hiding this comment.
Reviewed the full diff (24 files), CI, and the current state of main. This is a clean, backward-compatible terminology refactor — nicely done. Verified that every file on main referencing adopt.md / unadopt.md is repointed here, so the rename leaves no dangling links, and the renames preserve history. CI is all green.
Two things before merge:
-
Rebase needed — the PR is currently conflicting.
mainhas moved since this branched: #902 (Codex CLI runtime) editedadopt.mdandunadopt.mdafter the branch point, which creates a rename/edit conflict. The good news is #902 added no new references to the old filenames elsewhere, so the rebase is just folding its content edits into the renamedinstall.md/uninstall.md. -
Consistency nit in
skills/setup/SKILL.md. The lineMain-checkout-only sub-actions (
adopt,upgrade,unadopt) …still names the old primaries. It's harmless (they're valid aliases), but for consistency with making
install/uninstallprimary it'd read better asinstall,upgrade,uninstall.
Process checks (per AGENTS.md): since this touches skills, worth confirming the setup eval suite still passes (a pure rename shouldn't move behavior, but the rule asks for it) and that tools/spec-loop/.last-sync is current before pushing the rebase.
Nothing blocking on the substance — LGTM once rebased and the SKILL.md line is updated.
Now that Magpie can be installed from agent marketplaces, 'install' is the more familiar term than 'adopt'. Make it the primary command surface: - /magpie-setup install (default, no-arg) is first-time install; 'adopt' is a documented alias. - /magpie-setup uninstall reverses it; 'unadopt' is a documented alias. - Rename adopt.md -> install.md, unadopt.md -> uninstall.md (skills + docs); repoint all path references. - Keep the 'adopter'/'adopter repo' noun and the 'Adopt a Magpie' slogan. Command surface only (PR A). The wider docs/skills prose reword of the adopt->install verb is a separate follow-up (PR B).
…' for the mechanism Per the terminology model: a project *adopts* Magpie (the relationship); the *installation* is the process/mechanism. Restores 'Adopt and maintain ... via the snapshot-based installation mechanism' in the skill description; the install/uninstall command names and adopt/unadopt aliases are unchanged.
…s install
- Reword process-y 'adoption/adopt flow' phrases to 'install/installation'
where they describe the mechanism (the adopt/install flow, first-time
install, during installation, install recipe/instructions, uninstall flow),
and prefer '/magpie-setup install' in how-to steps. Relationship/noun uses
('adopter', 'adopter repo', 'a project adopts Magpie', 'adoption model')
and the adopt/unadopt aliases are left untouched.
- Add an 'Adoption vs. installation' note to docs/setup/README.md: a project
ADOPTS Magpie (relationship); INSTALLATION is the process (adopt = alias).
9210ebb to
8adc5a0
Compare
3 participants
Now that Magpie can be installed from agent marketplaces (#907), "install" is the more familiar term than "adopt." This makes
install/uninstallthe primary command surface, withadopt/unadoptkept as aliases (nothing breaks for anyone using them).Changes
/magpie-setup install— first-time install (the default no-arg action);/magpie-setup adoptis a documented alias./magpie-setup uninstall— reverses it;/magpie-setup unadoptis a documented alias.skills/setup/adopt.md→install.md,skills/setup/unadopt.md→uninstall.md, anddocs/setup/unadopt.md→uninstall.md; all path references repointed.argument-hint, sub-action list, and command table.Deliberately kept
Scope: command surface + file renames only. Part of the adoption→installation terminology shift discussed on the list.