Defer creation of locking model to ActivateOptions()#95
Merged
fluffynuts merged 2 commits intoapache:masterfrom Oct 24, 2022
Merged
Defer creation of locking model to ActivateOptions()#95fluffynuts merged 2 commits intoapache:masterfrom
fluffynuts merged 2 commits intoapache:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The creation of the locking model instance is now deferred to ActivateOptions() so that defaultLockingModelType has an effect.
@fluffynuts Could you please review?