Skip to content

Fix inclomplete byte-buddy upgrade to 1.18.8#2580

Closed
holgerfriedrich wants to merge 1 commit into
apache:karaf-4.4.xfrom
holgerfriedrich:pr-bb
Closed

Fix inclomplete byte-buddy upgrade to 1.18.8#2580
holgerfriedrich wants to merge 1 commit into
apache:karaf-4.4.xfrom
holgerfriedrich:pr-bb

Conversation

@holgerfriedrich
Copy link
Copy Markdown
Contributor

@holgerfriedrich holgerfriedrich commented Apr 24, 2026

Refs: #2563

@holgerfriedrich
Copy link
Copy Markdown
Contributor Author

@jbonofre there is one more occurrence of and older version of byte-buddy in the same file. It is used in hibernate feature.
Don't know how to proceed with this, it is very old and did not match the 1.17.5 we had before.

@jbonofre
Copy link
Copy Markdown
Member

Generally speaking, the "hard coded" version in the features are correct because it matches the expection of the feature. That's the main reason we are using specific version here (not the maven property).
So, I don't think we should update the feature here.

@holgerfriedrich
Copy link
Copy Markdown
Contributor Author

holgerfriedrich commented Apr 24, 2026

Ok, lets keep the older one for the hibernate feature.

What about the hibernate6 feature proposed change? 1.17.5 does not match the library requirements in hibernate6 as well (6.6.18-final seems to use 1.15.11). Though, I did not check the other libs in the feature.
1.17.5 -> 1.18.8 is the change which was done in #2563.

@jbonofre
Copy link
Copy Markdown
Member

Yes, indeed, I was maybe too agressive in the new hibernate6 feature. It works because the hibernate wrap is using "large range" import but worth to align.
We should check hibernate6 dependencies to align the expected versions.

@holgerfriedrich
Copy link
Copy Markdown
Contributor Author

I am fine if we do not proceed with my 2 PRs (feel free to close them).
I just noticed the inconsistency when building my app on top (which resolves automatically to stax2-api 4.2.2 and byte-buddy 1.17.7 due to other dependencies anyway, regardless of this change).

@jbonofre
Copy link
Copy Markdown
Member

Same as stax2-api, let's revert #2563

@jbonofre jbonofre closed this Apr 24, 2026
@holgerfriedrich holgerfriedrich deleted the pr-bb branch April 26, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants