Skip to content

Fix inclomplete stax2-api upgrade to 4.3.0#2579

Closed
holgerfriedrich wants to merge 1 commit into
apache:karaf-4.4.xfrom
holgerfriedrich:pr-stax
Closed

Fix inclomplete stax2-api upgrade to 4.3.0#2579
holgerfriedrich wants to merge 1 commit into
apache:karaf-4.4.xfrom
holgerfriedrich:pr-stax

Conversation

@holgerfriedrich
Copy link
Copy Markdown
Contributor

@holgerfriedrich holgerfriedrich commented Apr 24, 2026

Refs: #2565

@jbonofre
Copy link
Copy Markdown
Member

So, generally speaking we should not touch the "hard coded" version in features XML, because these versions are really needed to resolve the feature. It doesn't intentionally use Maven property here. I think a better fix would be to use Maven properties where it makes sense (and applicable), but not systemically change the versions in features XML.

@jbonofre jbonofre self-requested a review April 24, 2026 07:48
@holgerfriedrich
Copy link
Copy Markdown
Contributor Author

I am fine if we do not proceed with my 2 PRs (feel free to close them).
I just noticed the inconsistency when building my app on top (which resolves automatically to stax2-api 4.2.2 and byte-buddy 1.17.7 due to other dependencies anyway, regardless of this change).

@jbonofre
Copy link
Copy Markdown
Member

@holgerfriedrich let me review: if it doesn't break anything, it's worth to update 😄

@jbonofre
Copy link
Copy Markdown
Member

Hibernate6 is still happy, and the camel-blueprint is also happy.

However, I'm in favor to revert #2565 just in case on karaf-4.4.x.

@jbonofre jbonofre closed this Apr 24, 2026
@holgerfriedrich holgerfriedrich deleted the pr-stax branch April 26, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants