fix(tooling): use LinkedHashSet for deterministic option ordering (backport to 4.4.x)#2337
Merged
Merged
Conversation
…help generation (#2306) * Revert "Use single file generation to avoid verify race condition (#2285)" This reverts commit 3b067c9. * fix(tooling): use LinkedHashSet for deterministic option ordering in help generation Replace HashSet with LinkedHashSet in all CommandHelpPrinter implementations (Markdown, AsciiDoctor, DocBook, UserConf) to preserve insertion order of options. HashSet provides no ordering guarantee, causing non-deterministic output that breaks the test-commands-generate-help invoker test when dependencies change (e.g. jline upgrade from 3.30.6 to 3.30.8).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test-commands-generate-helpinvoker test that is also causing Bump org.jline:jline from 3.30.6 to 3.30.8 (backport to 4.4.x) #2335 to fail