Skip to content

fix(shell): prevent LinkageError from killing the local console thread (karaf-4.4.x) #2316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbonofre merged 1 commit into from
Mar 14, 2026
Merged

fix(shell): prevent LinkageError from killing the local console thread (karaf-4.4.x) #2316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions shell/core/src/main/java/org/apache/karaf/shell/impl/console/ConsoleSessionImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,6 +473,7 @@ private CharSequence readCommand(AtomicBoolean reading) throws UserInterruptExce
command = "";
} catch (Throwable t) {
ShellUtil.logException(this, t);
command = "";
} finally {
reading.set(false);
}
Expand Down
5 changes: 3 additions & 2 deletions shell/core/src/main/java/org/apache/karaf/shell/support/ShellUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,9 @@ public static void logException(Session session, Throwable t) {
session.getConsole().println(str);
}
session.getConsole().flush();
} catch (Exception ignore) {
// ignore
} catch (Throwable ignore) {
// ignore (catch Throwable to handle LinkageError from JLine classloader
// changes during bundle refresh, which would otherwise kill the console thread)
}
}

Expand Down
Loading