Skip to content

Set features and kar artifact to the corresponding mojo #2114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbonofre merged 3 commits into from
Nov 14, 2025
Merged

Set features and kar artifact to the corresponding mojo #2114

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b4f310
Deal with Kar packaging and cleanly attach artifact forcing pom packa…
jbonofre Nov 12, 2025
9059513
Deal with feature packaging
jbonofre Nov 13, 2025
80e8cac
Also deal with packaging in the case generation is not enabled.
jbonofre Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions ...-maven-plugin/src/main/java/org/apache/karaf/tooling/features/GenerateDescriptorMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,10 +346,13 @@ public void execute() throws MojoExecutionException, MojoFailureException {
filter(inputFile, outputFile);
getLog().info("Generation not enabled");
getLog().info("Attaching artifact");
//projectHelper.attachArtifact(project, attachmentArtifactType, attachmentArtifactClassifier, outputFile);
Artifact artifact = factory.createArtifactWithClassifier(project.getGroupId(), project.getArtifactId(), project.getVersion(), attachmentArtifactType, attachmentArtifactClassifier);
artifact.setFile(outputFile);
project.setArtifact(artifact);
if (project.getPackaging().equals("feature")) {
Artifact artifact = factory.createArtifactWithClassifier(project.getGroupId(), project.getArtifactId(), project.getVersion(), attachmentArtifactType, attachmentArtifactClassifier);
artifact.setFile(outputFile);
project.setArtifact(artifact);
} else {
projectHelper.attachArtifact(project, attachmentArtifactType, attachmentArtifactClassifier, outputFile);
}
return;
}
}
Expand All @@ -364,9 +367,17 @@ public void execute() throws MojoExecutionException, MojoFailureException {
try (PrintStream out = new PrintStream(new FileOutputStream(outputFile))) {
writeFeatures(out);
}
getLog().info("Attaching features XML");
// now lets attach it
projectHelper.attachArtifact(project, attachmentArtifactType, attachmentArtifactClassifier, outputFile);
if (project.getPackaging().equals("feature") && enableGeneration) {
getLog().info("Set artifact");
Artifact artifact = factory.createArtifactWithClassifier(project.getGroupId(), project.getArtifactId(), project.getVersion(), attachmentArtifactType
, FEATURE_CLASSIFIER);
artifact.setFile(outputFile);
project.setArtifact(artifact);
} else {
getLog().info("Attaching features XML");
// now lets attach it
projectHelper.attachArtifact(project, attachmentArtifactType, attachmentArtifactClassifier, outputFile);
}
} else {
throw new MojoExecutionException("Could not create directory for features file: " + dir);
}
Expand Down