Fix incomplete upgrade of commons-lang3#2073
Merged
Merged
Conversation
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Member
|
Good catch. We actually have a problem on GitHub Action: it executes the tests, but not the itests. I'm fixing that in a separate PR. |
jbonofre
approved these changes
Sep 30, 2025
jbonofre
pushed a commit
to jbonofre/karaf
that referenced
this pull request
Sep 30, 2025
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
jbonofre
added a commit
that referenced
this pull request
Oct 5, 2025
MrEasy
pushed a commit
to seeburger-ag/karaf
that referenced
this pull request
Nov 10, 2025
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de> Co-authored-by: Holger Friedrich <mail@holger-friedrich.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required to get the use-base-version test in karaf-maven-plugin pass.
I don't know why the CI passed at that time.
This is the error the PR is fixing:
To see that this is the root cause, one needs to remove the try-catch blocks from the tests.
Then the tests print the exception when failing.
I will create another PR for this.