Skip to content

[ENHANCEMENT] MailetContainer should record loggedIn user in MDC#2950

Merged
chibenwa merged 2 commits intoapache:masterfrom
chibenwa:logged-in-user-mdc
Feb 27, 2026
Merged

[ENHANCEMENT] MailetContainer should record loggedIn user in MDC#2950
chibenwa merged 2 commits intoapache:masterfrom
chibenwa:logged-in-user-mdc

Conversation

@chibenwa
Copy link
Contributor

  • Remove coupling on org.apache.james.jmap.send.MailMetaData.username
  • Record this info that allows for auditability of the sending decision in logs
  • Mutualize MDC instanciation for mailet and matcher

@chibenwa chibenwa self-assigned this Feb 25, 2026
@chibenwa chibenwa changed the title [FIX] MailetContainer should record loggedIn user in MDC [ENHANCEMENT] MailetContainer should record loggedIn user in MDC Feb 25, 2026
Copy link
Contributor

@jeantil jeantil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great addition, I have a minor suggestion but nice!

@chibenwa
Copy link
Contributor Author

That's a great addition, I have a minor suggestion but nice!

Nice to see enthusiasm!

The minor suggestion seem to be lost in GitHub however...

@jeantil
Copy link
Contributor

jeantil commented Feb 26, 2026

The minor suggestion seem to be lost in GitHub however...

weird I srtarted by the suggestion and expected it to be takne in the review.. 🤷

@chibenwa
Copy link
Contributor Author

weird I srtarted by the suggestion and expected it to be takne in the review.. 🤷

Could happen if comments are added to a review but the review isn't validated.

I added the default method in the Mail object which indeed looks better.

@chibenwa chibenwa merged commit 164afea into apache:master Feb 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants