Add support for timestamp with local zone in Hive3#1897
Merged
rdblue merged 9 commits intoapache:masterfrom Dec 12, 2020
Merged
Add support for timestamp with local zone in Hive3#1897rdblue merged 9 commits intoapache:masterfrom
rdblue merged 9 commits intoapache:masterfrom
Conversation
Collaborator
Author
|
@pvary can you please review when you have the chance? |
pvary
reviewed
Dec 10, 2020
...a/org/apache/iceberg/mr/hive/serde/objectinspector/IcebergTimestampObjectInspectorHive3.java
Show resolved
Hide resolved
pvary
reviewed
Dec 10, 2020
.../iceberg/mr/hive/serde/objectinspector/TestIcebergTimestampWithZoneObjectInspectorHive3.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Dec 10, 2020
.../iceberg/mr/hive/serde/objectinspector/TestIcebergTimestampWithZoneObjectInspectorHive3.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Dec 10, 2020
...n/java/org/apache/iceberg/mr/hive/serde/objectinspector/IcebergTimestampObjectInspector.java
Show resolved
Hide resolved
Contributor
|
Do we need to change |
Collaborator
Author
Yes, good point. I'll modify the |
pvary
reviewed
Dec 11, 2020
...a/org/apache/iceberg/mr/hive/serde/objectinspector/IcebergTimestampObjectInspectorHive3.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Dec 11, 2020
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveSchemaConverter.java
Outdated
Show resolved
Hide resolved
Contributor
|
@pvary, please ping me when this is ready to merge. |
pvary
reviewed
Dec 11, 2020
hive3/src/test/java/org/apache/iceberg/mr/hive/TestHiveSchemaUtilHive3.java
Show resolved
Hide resolved
pvary
reviewed
Dec 11, 2020
...g/apache/iceberg/mr/hive/serde/objectinspector/TestIcebergTimestampObjectInspectorHive3.java
Outdated
Show resolved
Hide resolved
pvary
approved these changes
Dec 12, 2020
Contributor
pvary
left a comment
pvary
left a comment
There was a problem hiding this comment.
Thanks @marton-bod!
@rdblue, I think this patch is good to go after the tests are finished
Contributor
|
Merged. Thanks @marton-bod, and thanks for reviewing, @pvary! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TimestampObjectInspectorclasses into two separate classes for (i) normal timestamps and (ii) timestamps with zone (instead of using inner classes)