Improve test_version_format() error message for version mismatches#991
Closed
laksh-krishna-sharma wants to merge 3 commits intoapache:mainfrom
laksh-krishna-sharma:feat/949-library-version-upgrade-fails-test-version-format
Closed
Improve test_version_format() error message for version mismatches#991laksh-krishna-sharma wants to merge 3 commits intoapache:mainfrom laksh-krishna-sharma:feat/949-library-version-upgrade-fails-test-version-format
laksh-krishna-sharma wants to merge 3 commits intoapache:mainfrom
laksh-krishna-sharma:feat/949-library-version-upgrade-fails-test-version-format
Conversation
Contributor
Author
|
Sir I have resolved the issue carefully. Please review the updated. |
kevinjqliu
reviewed
Aug 2, 2024
Contributor
Author
|
Thank you for your feedback, @kevinjqliu . I have resolved the issue carefully . Please review the updated. |
Contributor
Author
|
Sir, is there any new or further update? |
Contributor
Author
|
I will investigate the issue and address the failing tests as soon as possible. I'll update once the problem is resolved. |
Contributor
|
Thanks @laksh-krishna-sharma You can run |
Fokko
approved these changes
Aug 6, 2024
Contributor
|
Closed in favor of #1015 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This PR Address?
Enhances the test_version_format() Error Message for Version Mismatches.
Fixes #949
Description
This PR enhances the test_version_format() function in tests/test_version.py by updating the error message to be more informative. The new message provides clearer guidance on resolving version mismatch issues, including a suggestion to rerun make install if needed.