Conversation
Fokko
left a comment
There was a problem hiding this comment.
Thanks for working on this @himadripal. Can you fix the conflicts? Thanks!
|
@Fokko Thank you for the approval. Fixed the conflict, can you please let the build checks run? |
|
The easiest way is to fix this locally using |
@Fokko Thank you for this tip. |
|
locally all passed (venv) % poetry run pre-commit run --all-files
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check docstring is first.................................................Passed
debug statements (python)................................................Passed
check yaml...............................................................Passed
check python ast.........................................................Passed
ruff.....................................................................Passed
ruff-format..............................................................Passed
mypy.....................................................................Passed
pycln....................................................................Passed
mdformat.................................................................Passed
pydocstyle...............................................................Passed
flynt....................................................................Passed@Fokko Can you rerun the build check please? |
adfdea2 to
e508a9f
Compare
added scope as configurable option, defaults to `CATALOG_SCOPE` resolve conflicts. change to constant style fix
01f6541 to
f9635a6
Compare
Fokko
left a comment
There was a problem hiding this comment.
Looks good. Could you also create a PR to update the documentation:
iceberg-python/mkdocs/docs/configuration.md
Line 152 in 36b56eb
flyrain
left a comment
There was a problem hiding this comment.
+1 thanks @himadripal for working on it.
|
Thanks for working on this @himadripal and for the review @flyrain |
#462