Refactor glue to iceberg table conversion#2660
Merged
kevinjqliu merged 1 commit intoapache:mainfrom Oct 25, 2025
Merged
Conversation
3 tasks
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the _convert_glue_to_iceberg method in the Glue catalog to use the walrus operator (:=) for inline assignment and validation. The changes eliminate an unused properties variable that was assigned but never referenced, and consolidate dictionary access with null checks using the walrus operator pattern.
Key Changes:
- Removed unused
propertiesvariable assignment - Converted dictionary access patterns to use walrus operator with inline null checks
- Changed direct key access (
glue_table["Name"]) to safer.get()method with validation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kevinjqliu
approved these changes
Oct 25, 2025
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM thanks for the refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Note: Opening this to verify auto-run CI behavior.
This also includes a small refactor to
_convert_glue_to_iceberg. We were assigning parameters early and never using it. Since we only need specific values from Parameters, this change uses the walrus operator to read them inline and removes the unused variable.Are these changes tested?
Yes
Are there any user-facing changes?
No