Feat/add support kerberize hivemetastore#1634
Conversation
…-support-kerberize-hivemetastore
Fokko
force-pushed
the
feat/add-support-kerberize-hivemetastore
branch
from
e6610b1 to
3ab287f
Compare
Fokko
force-pushed
the
feat/add-support-kerberize-hivemetastore
branch
from
3ab287f to
38d9c2c
Compare
|
It is not maintained anymore: https://github.com/apple/ccs-pykerberos |
|
i think to get around this, we need to install some packages on the github runner os |
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
I realized that we dont really have a way to verify that this implementation is correct
pyproject.toml
Outdated
| cachetools = "^5.5.0" | ||
| pyiceberg-core = { version = "^0.4.0", optional = true } | ||
| thrift-sasl = { version = ">=0.4.3", optional = true } | ||
| kerberos = { version = "1.3.1", optional = true } |
There was a problem hiding this comment.
this is causing the CI issue. Im not sure if we really require this dependency
There was a problem hiding this comment.
Good call, let me check! I was surprised by how little there was as an alternative to this dependency, it is pretty likely that it is not needed at all.
…-support-kerberize-hivemetastore
| return _HiveClient( | ||
| uri, | ||
| properties.get("ugi"), | ||
| property_as_bool(properties, HIVE_KERBEROS_AUTH, HIVE_KERBEROS_AUTH_DEFAULT), |
There was a problem hiding this comment.
this change is causing a few tests to fail, we need to add the extra arg to the tests
like so https://github.com/kevinjqliu/iceberg-python/pull/10/files#diff-8a0f847796be6745b3be158f5c39d0e83cbb868c162763a13895175b484cc529
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM! Let's merge this and iterate if necessary
3 participants
Took #766 and addressed the comments, to make sure that it gets into 0.9.0