patch: Parquet Column Names with "Special Characters" fix#109
Conversation
|
Exception Example (before hack): After the hack I can read the dataframe, would love some guidance on where you all think something like this is most appropiate. |
Contributor
Author
|
Will test and close, unit test wise looks like #83 is the fix. |
This PR can be closed, confirmed fix is in master. |
Contributor
|
Thanks you both @MarquisC and @mchamberlain-mdsol for checking this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're using PyIceberg to read Iceberg tables stored in S3 as parquet. We have column names in the form of
id:foodiagnostic:barusing:as a sort of delimiter to help us do some programatic maintenance on our side.In Parquet the column names are magically subbed in this case
:->_x3Aand upon attempts at scanning/reading the data the schema of the table doesn't match the physical column names for PyArrow.The first pass is a naive fix for this that I have tested and works, but I'm looking for guidance on where you all want me to put this logic, and I'm happy to add it there instead.