HBASE-23575 Remove dead code in AsyncRegistry (#929)

[bharathv]

Removes a bunch of dead code and fixes some checkstyle nits.

Signed-off-by: Viraj Jasani virajjasani007@gmail.com
Signed-off-by: Sean Busbey busbey@apache.org
(cherry picked from commit efa4fe9)

[bharathv]

@busbey for branch-2, FYI.

[busbey]

I'm +1 pending QAbot.

[busbey]

thanks for the quick turn around @bharathv!

[HorizonNet]

LGTM

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 3s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 7 new or modified test files.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 17s	branch-2 passed
+1 💚	compile	1m 26s	branch-2 passed
+1 💚	checkstyle	1m 59s	branch-2 passed
+1 💚	shadedjars	4m 27s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 3s	branch-2 passed
+0 🆗	spotbugs	3m 33s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	4m 48s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 3s	the patch passed
+1 💚	compile	1m 24s	the patch passed
+1 💚	javac	1m 24s	the patch passed
-1 ❌	checkstyle	1m 20s	hbase-server: The patch generated 1 new + 27 unchanged - 0 fixed = 28 total (was 27)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	4m 22s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	15m 38s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	1m 0s	the patch passed
+1 💚	findbugs	4m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 34s	hbase-client in the patch passed.
+1 💚	unit	159m 56s	hbase-server in the patch passed.
+1 💚	asflicense	0m 51s	The patch does not generate ASF License warnings.
		226m 43s

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-940/1/artifact/out/Dockerfile
GITHUB PR	#940
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 594ec439ee1c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-940/out/precommit/personality/provided.sh
git revision	branch-2 / f9abaee
Default Java	1.8.0_181
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-940/1/artifact/out/diff-checkstyle-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-940/1/testReport/
Max. process+thread count	4672 (vs. ulimit of 10000)
modules	C: hbase-client hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-940/1/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 7 new or modified test files.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 16s	branch-2 passed
+1 💚	compile	1m 19s	branch-2 passed
+1 💚	checkstyle	1m 58s	branch-2 passed
+1 💚	shadedjars	4m 14s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 59s	branch-2 passed
+0 🆗	spotbugs	3m 24s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	4m 35s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 54s	the patch passed
+1 💚	compile	1m 22s	the patch passed
+1 💚	javac	1m 22s	the patch passed
+1 💚	checkstyle	0m 37s	The patch passed checkstyle in hbase-client
+1 💚	checkstyle	1m 18s	hbase-server: The patch generated 0 new + 26 unchanged - 1 fixed = 26 total (was 27)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	4m 11s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	15m 19s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	1m 1s	the patch passed
+1 💚	findbugs	4m 46s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 32s	hbase-client in the patch passed.
+1 💚	unit	158m 2s	hbase-server in the patch passed.
+1 💚	asflicense	1m 0s	The patch does not generate ASF License warnings.
		222m 0s

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-940/2/artifact/out/Dockerfile
GITHUB PR	#940
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux f7b1bc60c7b7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-940/out/precommit/personality/provided.sh
git revision	branch-2 / acb6b7c
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-940/2/testReport/
Max. process+thread count	4806 (vs. ulimit of 10000)
modules	C: hbase-client hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-940/2/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[busbey]

okay let me update the signed-off-by list and merge this to the last few branches.

[bharathv]

Thanks for the reviews.