HBASE-28565 Make map reduce jobs accept connection uri when specifyin…#5972
HBASE-28565 Make map reduce jobs accept connection uri when specifyin…#5972Apache9 merged 1 commit intoapache:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
ndimiduk
left a comment
There was a problem hiding this comment.
Looks good, I have just a couple small suggestions. Thanks for the exhaustive test coverage.
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/TableOutputFormat.java
Outdated
Show resolved
Hide resolved
| import org.junit.experimental.categories.Category; | ||
|
|
||
| @Category({ MapReduceTests.class, LargeTests.class }) | ||
| public class TestCopyTableToPeerClusterWithClusterKey extends CopyTableToPeerClusterTestBase { |
There was a problem hiding this comment.
Oof. It would be nice if we could verify this "simple" change without needing to actually run these map-reduce jobs. But yes, I understand why you've added them.
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduceUtil.java
Outdated
Show resolved
Hide resolved
| tokenForCluster.decodeIdentifier().getUsername()); | ||
| } | ||
| } finally { | ||
| kdc.stop(); |
There was a problem hiding this comment.
I'm surprised to see that MiniKdc is not AutoCloseable.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
…g peer cluster