HBASE-22941 merge operation returns parent regions in random order#556
Merged
saintstack merged 4 commits intoapache:masterfrom Aug 29, 2019
Merged
HBASE-22941 merge operation returns parent regions in random order#556saintstack merged 4 commits intoapache:masterfrom
saintstack merged 4 commits intoapache:masterfrom
Conversation
store and return the merge parent regions in ascending order remove left over check for exactly two merged regions add unit test
saintstack
approved these changes
Aug 28, 2019
Contributor
saintstack
left a comment
saintstack
left a comment
There was a problem hiding this comment.
Thanks for the fixes (and obviously, the testing that found these bugs). LGTM.
Will see how it does on build and will push if all good.
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStateStore.java
Outdated
Show resolved
Hide resolved
| for (int c = 0; c < 19; c++) { | ||
| assertTrue(Bytes.compareTo(mergeParentRegions.get(c).getStartKey(), mergeParentRegions.get(c+1).getStartKey())<0); | ||
| } | ||
|
|
|
💔 -1 overall
This message was automatically generated. |
| for (int c = 0; c < 19; c++) { | ||
| assertTrue(Bytes.compareTo(mergeParentRegions.get(c).getStartKey(), mergeParentRegions.get(c+1).getStartKey())<0); | ||
| } | ||
|
|
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
asfgit
pushed a commit
that referenced
this pull request
Aug 29, 2019
…556) Minor addendum to address checkstyle issue
Contributor
|
Fixed checkstyle complaint in a follow-on addendum. |
asfgit
pushed a commit
that referenced
this pull request
Aug 29, 2019
) * HBASE-22941 merge operation returns parent regions in random order store and return the merge parent regions in ascending order remove left over check for exactly two merged regions add unit test * use SortedMap type to emphasise that the Map is sorted. * use regionCount consistently and checkstyle fixes * Delete tests that expect multiregion merges to fail. Signed-off-by: stack <stack@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Sep 20, 2019
) * HBASE-22941 merge operation returns parent regions in random order store and return the merge parent regions in ascending order remove left over check for exactly two merged regions add unit test * use SortedMap type to emphasise that the Map is sorted. * use regionCount consistently and checkstyle fixes * Delete tests that expect multiregion merges to fail. Signed-off-by: stack <stack@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Sep 20, 2019
) * HBASE-22941 merge operation returns parent regions in random order store and return the merge parent regions in ascending order remove left over check for exactly two merged regions add unit test * use SortedMap type to emphasise that the Map is sorted. * use regionCount consistently and checkstyle fixes * Delete tests that expect multiregion merges to fail. Signed-off-by: stack <stack@apache.org>
infraio
pushed a commit
to infraio/hbase
that referenced
this pull request
Aug 17, 2020
…pache#556) * HBASE-22941 merge operation returns parent regions in random order store and return the merge parent regions in ascending order remove left over check for exactly two merged regions add unit test * use SortedMap type to emphasise that the Map is sorted. * use regionCount consistently and checkstyle fixes * Delete tests that expect multiregion merges to fail. Signed-off-by: stack <stack@apache.org>
symat
pushed a commit
to symat/hbase
that referenced
this pull request
Feb 17, 2021
…pache#556) * HBASE-22941 merge operation returns parent regions in random order store and return the merge parent regions in ascending order remove left over check for exactly two merged regions add unit test * use SortedMap type to emphasise that the Map is sorted. * use regionCount consistently and checkstyle fixes * Delete tests that expect multiregion merges to fail. Signed-off-by: stack <stack@apache.org> (cherry picked from commit 047aad1) Change-Id: I081888b3205db4c34dc5df466edcdf34aae3cd76
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
store and return the merge parent regions in ascending order
remove left over check for exactly two merged regions
add unit test