HBASE-27347 Port FileWatcher from ZK to autodetect keystore/truststore changes in TLS connections#4869
Merged
wchevreuil merged 6 commits intoapache:masterfrom Nov 11, 2022
Merged
Conversation
|
🎊 +1 overall
This message was automatically generated. |
wchevreuil
reviewed
Nov 9, 2022
Contributor
wchevreuil
left a comment
wchevreuil
left a comment
There was a problem hiding this comment.
LGTM, overall, just have some minor remarks.
| } | ||
| // Note: we don't care about delete events | ||
| if (shouldResetContext) { | ||
| if (LOG.isDebugEnabled()) { |
Contributor
There was a problem hiding this comment.
nit: Maybe worth info logging? My thought here is that this wouldn't be a frequent event, yet a important one to get logged at higher level than debugging.
| resetContext.run(); | ||
| } else { | ||
| if (LOG.isDebugEnabled()) { | ||
| LOG.debug("Ignoring watch event and keeping previous default SSL context. Event kind: " |
Contributor
There was a problem hiding this comment.
nit: parameterized logging?
| * revision</a> | ||
| */ | ||
| @InterfaceAudience.Private | ||
| public final class FileChangeWatcher { |
Contributor
There was a problem hiding this comment.
Is this a straight copy from Zookeeper? Couldn't we just reuse the ZK impl directly, as we already have ZK as a dependency?
Contributor
Author
There was a problem hiding this comment.
Urm... I don't have a strong opinion. We were following this pattern in the entire implementation of TLS. It's probably better to stay on the safe side and avoid sideeffects of ZK non-backward compatible changes. They're quite unlikely though.
Contributor
There was a problem hiding this comment.
Thanks for clarifying. Not a big deal for me. And on the flip side, it would be actually a bit weird to depend on ZK for a functionality that isn't really ZK specific, so I'm ok with this copy approach.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
wchevreuil
approved these changes
Nov 10, 2022
Contributor
Author
|
Thanks @wchevreuil for merging the patch. Please cherry pick it to branch-2 as well. |
bbeaudreault
pushed a commit
to HubSpot/hbase
that referenced
this pull request
Nov 16, 2022
…e changes in TLS connections (apache#4869) Signed-off-by: wchevreuil@apache.org
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch is the port of ZooKeeper's FileWatcher's functionality which we can take advantage to detect changes in truststore / keystore files for TLS. Cert / key renewal processes don't need HBase services to be restarted with this patch.
cc @bbeaudreault @Apache9