HBASE-27152 Under compaction mark may leak#4725
Merged
sunhelly merged 1 commit intoapache:masterfrom Aug 29, 2022
Merged
Conversation
|
🎊 +1 overall
This message was automatically generated. |
Apache9
reviewed
Aug 25, 2022
| final String n = Thread.currentThread().getName(); | ||
|
|
||
| StealJobQueue<Runnable> stealJobQueue = new StealJobQueue<Runnable>(COMPARATOR); | ||
| // Since the StealJobQueue is unbounded, we need not to set the RejectedExecutionHandler for |
Contributor
There was a problem hiding this comment.
This could be done as a separated issue? And what is the disadvantage to set the rejection handler, seems no harm?
Contributor
Author
There was a problem hiding this comment.
Actually the max size of StealJobQueue is bouded by the VM limit of an array, and the OOM exception occurs before the rejection handler. So StealJobQueue is equivalent to be unbounded. I think the RejectionHandler may bring some confusions and make the codes a little puzzle.
I will seperate the removing the rejection handler here in another issue. Thanks.
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
Apache9
approved these changes
Aug 27, 2022
sunhelly
added a commit
to sunhelly/hbase
that referenced
this pull request
Aug 29, 2022
Signed-off-by: Duo Zhang <zhangduo@apache.org>
sunhelly
added a commit
to sunhelly/hbase
that referenced
this pull request
Aug 29, 2022
Signed-off-by: Duo Zhang <zhangduo@apache.org>
sunhelly
added a commit
that referenced
this pull request
Aug 29, 2022
Signed-off-by: Duo Zhang <zhangduo@apache.org>
sunhelly
added a commit
that referenced
this pull request
Aug 29, 2022
Signed-off-by: Duo Zhang <zhangduo@apache.org>
bbeaudreault
pushed a commit
to HubSpot/hbase
that referenced
this pull request
Sep 23, 2022
Signed-off-by: Duo Zhang <zhangduo@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.