HBASE-22737 Add a new admin method and shell cmd to trigger the hbck …#425
Merged
infraio merged 1 commit intoapache:masterfrom Aug 1, 2019
Merged
HBASE-22737 Add a new admin method and shell cmd to trigger the hbck …#425infraio merged 1 commit intoapache:masterfrom
infraio merged 1 commit intoapache:masterfrom
Conversation
Contributor
|
Should this be in Admin? Or in Hbck? |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
saintstack
reviewed
Jul 29, 2019
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HbckChore.java
Show resolved
Hide resolved
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HbckChore.java
Show resolved
Hide resolved
| throws ServiceException { | ||
| rpcPreCheck("runHbckChore"); | ||
| HbckChore hbckChore = master.getHbckChore(); | ||
| if (!hbckChore.isRunning()) { |
Contributor
There was a problem hiding this comment.
If already running, should result of this call be 'false' for did not run?//
Contributor
Author
There was a problem hiding this comment.
Ok. Return false if the HBCK chore already running.
| #---------------------------------------------------------------------------------------------- | ||
| # Request HBCK chore to run | ||
| def hbck_chore_run | ||
| @admin.runHbckChore |
Contributor
There was a problem hiding this comment.
Yeah, good question by @duo regards whether it should be in hbcksevice or not. It probably should?
| def help | ||
| <<-EOF | ||
| Request HBCK chore to run at master side. | ||
|
|
Contributor
There was a problem hiding this comment.
Perhaps say what the chore does? One sentence?
Contributor
There was a problem hiding this comment.
Missing 'm' on Filesystem. Fix on commit.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
saintstack
approved these changes
Jul 31, 2019
Contributor
saintstack
left a comment
saintstack
left a comment
There was a problem hiding this comment.
Minor item to fix on commit.
| def help | ||
| <<-EOF | ||
| Request HBCK chore to run at master side. | ||
|
|
Contributor
There was a problem hiding this comment.
Missing 'm' on Filesystem. Fix on commit.
|
💔 -1 overall
This message was automatically generated. |
asfgit
pushed a commit
that referenced
this pull request
Aug 1, 2019
…chore to run (#425) Signed-off-by: stack <stack@apache.org>
|
💔 -1 overall
This message was automatically generated. |
asfgit
pushed a commit
that referenced
this pull request
Aug 1, 2019
…chore to run (#425) Signed-off-by: stack <stack@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Aug 1, 2019
…chore to run (#425) Signed-off-by: stack <stack@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Aug 1, 2019
…chore to run (#425) Signed-off-by: stack <stack@apache.org>
infraio
added a commit
to infraio/hbase
that referenced
this pull request
Aug 17, 2020
…chore to run (apache#425) Signed-off-by: stack <stack@apache.org>
symat
pushed a commit
to symat/hbase
that referenced
this pull request
Feb 17, 2021
…chore to run (apache#425) Signed-off-by: stack <stack@apache.org> (cherry picked from commit 5ec1fed) Change-Id: I1d4fa998b1f167bf292b819fc42f935cd2fc3ca0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…chore to run