HBASE-26210 HBase Write should be doomed to hang when cell size excee…#3604
HBASE-26210 HBase Write should be doomed to hang when cell size excee…#3604Apache9 merged 5 commits intoapache:masterfrom
Conversation
…ds InmemoryFlushSize for CompactingMemStore
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
left a comment
There was a problem hiding this comment.
Could you please explain a bit on the approach here? We just skip adding the size?
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactingMemStore.java
Show resolved
Hide resolved
|
@Apache9 , My PR not skip adding the size,it still add the size before really adding the cell to |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@Apache9 , Would you please help me have a review again at your convenience? Thank you very much. |
|
Need sometime to dive into the code... Code with concurrent is always the most difficult to review... Let me read your reply carefully first to see if I can get insight. Sorry for the delay, really not familiar with this part of code :( |
|
@Apache9 , thank you very much for reply, never mind. |
…ds InmemoryFlushSize for CompactingMemStore (#3604) Signed-off-by: Duo Zhang <zhangduo@apache.org>
…ds InmemoryFlushSize for CompactingMemStore (#3604) Signed-off-by: Duo Zhang <zhangduo@apache.org>
…ds InmemoryFlushSize for CompactingMemStore (#3604) Signed-off-by: Duo Zhang <zhangduo@apache.org>
…ds InmemoryFlushSize for CompactingMemStore