HBASE-26124 Backport HBASE-25373 "Remove HTrace completely in code base and try to make use of OpenTelemetry" to branch-2#3529
Merged
taklwu merged 7 commits intoapache:branch-2from Jul 29, 2021
Conversation
Contributor
Author
|
the original commit on master is 302d9ea |
…se and try to make use of OpenTelemetry" to branch-2 1/17 commits of HBASE-22120
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
The failed test TestSnapshotScannerHDFSAclController2 passed locally and the error of |
|
💔 -1 overall
This message was automatically generated. |
| <exclude>com.github.spotbugs:*</exclude> | ||
| <exclude>org.apache.htrace:*</exclude> | ||
| <exclude>org.apache.yetus:*</exclude> | ||
| <exclude>org.apache.logging.log4j:*</exclude> |
Contributor
There was a problem hiding this comment.
Not from the original commit. Is this needed?
Contributor
Author
There was a problem hiding this comment.
you're right, I will remove them
| <exclude>com.github.spotbugs:*</exclude> | ||
| <exclude>org.apache.htrace:*</exclude> | ||
| <exclude>org.apache.yetus:*</exclude> | ||
| <exclude>org.apache.logging.log4j:*</exclude> |
hbase-shaded/pom.xml
Outdated
| <exclude>com.github.spotbugs:*</exclude> | ||
| <exclude>org.apache.htrace:*</exclude> | ||
| <exclude>org.apache.yetus:*</exclude> | ||
| <exclude>org.apache.logging.log4j:*</exclude> |
Change-Id: Ifd1f02c142748f15f417a780a485b45cd5a94397
Change-Id: Ifce333131217ced6807b407fe66d85093b06728d
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
petersomogyi
approved these changes
Jul 28, 2021
Contributor
petersomogyi
left a comment
petersomogyi
left a comment
There was a problem hiding this comment.
lgtm after the javac, checkstyle and rubocop warnings are fixed.
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Change-Id: I2e1c41e50daaf353c5da8b0763677a69fe233de4
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Change-Id: I7b8b3df00465d7fc065cff7aa9b65d3878523a30
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
javac, checkstyle and rubocop have all been fixed, merging. |
Contributor
|
Be lated +1. Thanks @taklwu for taking this work. This PR seems OK to merge to branch-2 directly, but I'm not sure if is better to backport to a branch-2 based feature branch first for the other issues? |
Contributor
Author
|
@Apache9 hey Duo, having your +1 is good and it's never late to comment!. (updated) let me clarify with you first, do you mean we should have a single feature branch for all remaining commits (about 14 commits remaining) , then have a single PR for reviewing all cherry-picks (with merge conflicts) such we can move the review faster ? (in fact I actually had backported all 17 commits in my local repository) or, do you have other concerns for "the other issues" (what does "other" means here)? |
Contributor
This is a big new feature and until all the sub-tasks for HBASE-22120 are back port, the feature can be considered as 'complete'. So this means during the backporting, we have a partial implemented feature in one of our main branches, which is not good IMO. Thanks. |
Contributor
Author
|
cool, thanks @Apache9 Duo, I will open a feature branch HBASE-25853 based on branch-2 and and open up PRs with all remaining commits. |
taklwu
added a commit
to taklwu/hbase
that referenced
this pull request
Aug 4, 2021
… code base and try to make use of OpenTelemetry" to branch-2 (apache#3529)" This reverts commit f049301.
taklwu
added a commit
that referenced
this pull request
Aug 5, 2021
…se and try to make use of OpenTelemetry" to branch-2 (#3529) 1/17 commits of HBASE-22120 Signed-off-by: Peter Somogyi <psomogyi@apache.org>
taklwu
added a commit
that referenced
this pull request
Aug 27, 2021
…se and try to make use of OpenTelemetry" to branch-2 (#3529) 1/17 commits of HBASE-22120 Signed-off-by: Peter Somogyi <psomogyi@apache.org>
taklwu
added a commit
that referenced
this pull request
Sep 1, 2021
…se and try to make use of OpenTelemetry" to branch-2 (#3529) 1/17 commits of HBASE-22120 Signed-off-by: Peter Somogyi <psomogyi@apache.org>
vinayakphegde
pushed a commit
to vinayakphegde/hbase
that referenced
this pull request
Apr 4, 2024
…se and try to make use of OpenTelemetry" to branch-2 (apache#3529) 1/17 commits of HBASE-22120 Signed-off-by: Peter Somogyi <psomogyi@apache.org> (cherry picked from commit f049301) Ref: CDPD-32259 Reason: CVE / Security Notes: This is an directly backport from upstream f049301 instead of porting it from CDPD-26769 because branch-2.4 is mostly aligned with upstream branch-2. Change-Id: If50b88b45c2e1afc24a7924440651c7c68dc24e1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1/17 commits of HBASE-22120