HBASE-25830 HBaseCluster support CompactionServer for UTs (addendum)#3464
Merged
nyl3532016 merged 2 commits intoapache:HBASE-25714from Jul 14, 2021
Merged
HBASE-25830 HBaseCluster support CompactionServer for UTs (addendum)#3464nyl3532016 merged 2 commits intoapache:HBASE-25714from
nyl3532016 merged 2 commits intoapache:HBASE-25714from
Conversation
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
reviewed
Jul 11, 2021
| /** | ||
| * Starts a compaction server thread running | ||
| * | ||
| * @throws IOException |
Contributor
There was a problem hiding this comment.
nit: remove empty throws doc
| /** | ||
| * Wait for the specified compaction server to stop. Removes this thread from list | ||
| * of running threads. | ||
| * @param serverNumber |
Contributor
There was a problem hiding this comment.
nits: remove empty param doc
| TEST_UTIL.compact(TABLENAME, false); | ||
| TEST_UTIL.waitFor(6000, () -> COMPACTION_SERVER.requestCount.sum() > 0); | ||
| long requestCount = COMPACTION_SERVER.requestCount.sum(); | ||
| Thread.sleep(1000); |
Contributor
There was a problem hiding this comment.
Mind explaining a bit here?
Contributor
Author
There was a problem hiding this comment.
OK,this sleep is no need. My Initially thought is compact request is async, this sleep will make the check below effective, After view code I find the increment of request count on compaction server is sync in compaction request
|
🎊 +1 overall
This message was automatically generated. |
Apache9
approved these changes
Jul 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support create/shutdown compactionserver method in HBaseMinicluster
Fix weakness of TestCompactionServer