HBASE-22432 HRegionServer rssStub handling is incorrect and inconsistent#241
Closed
sershe-ms wants to merge 2 commits intoapache:masterfrom
Closed
HBASE-22432 HRegionServer rssStub handling is incorrect and inconsistent#241sershe-ms wants to merge 2 commits intoapache:masterfrom
sershe-ms wants to merge 2 commits intoapache:masterfrom
Conversation
Apache9
requested changes
May 16, 2019
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
Outdated
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
Apache9
requested changes
May 21, 2019
| while (rss == null && maxRetries-- >= 0 | ||
| && (clusterConnection != null && !clusterConnection.isClosed())) { | ||
| synchronized (rssStubLock) { | ||
| if (resetRssStub) { |
Contributor
There was a problem hiding this comment.
I do not fully understand what's the usage of this resetRssStub flag... We do not test it in the condition of the while loop?
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
@sershe-ms Could you please look into the merge conflict? |
Contributor
|
Close since the PR is stale and can not be merged. Feel free to reopen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.