HBASE-22072 High read/write intensive regions may cause long crash#214
Merged
ramkrish86 merged 2 commits intoapache:masterfrom May 8, 2019
Merged
HBASE-22072 High read/write intensive regions may cause long crash#214ramkrish86 merged 2 commits intoapache:masterfrom
ramkrish86 merged 2 commits intoapache:masterfrom
Conversation
|
💔 -1 overall
This message was automatically generated. |
Apache9
requested changes
May 3, 2019
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java
Outdated
Show resolved
Hide resolved
Member
|
Please check and fix the checkstyle issue as reported. The change itself looks good but I need some time to read and fully understand the issue and solution as discussed in HBASE-22072. Will be back once done. Thanks. |
anoopsjohn
reviewed
May 6, 2019
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
Show resolved
Hide resolved
anoopsjohn
requested changes
May 6, 2019
Contributor
anoopsjohn
left a comment
anoopsjohn
left a comment
There was a problem hiding this comment.
Pls address the volatile comment and then we are good to go.. I think this will solve many strange issues that we were seeing with the new way of delayed compacted files cleanup. Good one.
Contributor
Author
|
Made the 'closing' variable to volatile. fixed checkstyle issue and moved the test to a new class. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
Author
|
Seems all good now in terms of QA. |
ramkrish86
pushed a commit
that referenced
this pull request
May 8, 2019
) * HBASE-22072 High read/write intensive regions may cause long crash recovery * Make the 'closing' variable as volatile and move the test case to standlone class
ramkrish86
pushed a commit
that referenced
this pull request
May 8, 2019
) * HBASE-22072 High read/write intensive regions may cause long crash recovery * Make the 'closing' variable as volatile and move the test case to standlone class
ramkrish86
pushed a commit
that referenced
this pull request
May 8, 2019
) * HBASE-22072 High read/write intensive regions may cause long crash recovery * Make the 'closing' variable as volatile and move the test case to standlone class
ramkrish86
pushed a commit
that referenced
this pull request
May 8, 2019
) * HBASE-22072 High read/write intensive regions may cause long crash recovery * Make the 'closing' variable as volatile and move the test case to standlone class
infraio
pushed a commit
to infraio/hbase
that referenced
this pull request
Aug 17, 2020
…pache#214) * HBASE-22072 High read/write intensive regions may cause long crash recovery * Make the 'closing' variable as volatile and move the test case to standlone class
symat
pushed a commit
to symat/hbase
that referenced
this pull request
Feb 17, 2021
…pache#214) * HBASE-22072 High read/write intensive regions may cause long crash recovery * Make the 'closing' variable as volatile and move the test case to standlone class (cherry picked from commit 8d56693) Change-Id: I3bd6e4f030458516aebe3c7adb96712cbef16b20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows either updateReaders() or close() to happen at the same time. The JIRA reporter has tested the fix provided.