HBASE-23584 : Descrease rpc getFileStatus count when open a storefile#1380
Closed
HuiHang-Yu wants to merge 1 commit intoapache:masterfrom
HuiHang-Yu:master
Closed
HBASE-23584 : Descrease rpc getFileStatus count when open a storefile#1380HuiHang-Yu wants to merge 1 commit intoapache:masterfrom HuiHang-Yu:master
HuiHang-Yu wants to merge 1 commit intoapache:masterfrom
HuiHang-Yu:master
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
saintstack
reviewed
Mar 31, 2020
Contributor
saintstack
left a comment
saintstack
left a comment
There was a problem hiding this comment.
Patch is looking good. Some nits in below.
| this.createdTimestamp = fStatus.getModificationTime(); | ||
| this.size = fStatus.getLen(); | ||
| this.localStatus = fileStatus; | ||
| }else{ |
Contributor
There was a problem hiding this comment.
Please keep the style of the surrounding file; i.e. space between '}' and 'else' and after.
| } else { | ||
| throw new IOException("path=" + p + " doesn't look like a valid StoreFile"); | ||
| } | ||
| if(this.localStatus == null ){ |
Contributor
There was a problem hiding this comment.
See how spacing is done in rest of the file.
| } | ||
|
|
||
|
|
||
|
|
| status = fs.getFileStatus(initialPath); | ||
| } | ||
| if(null == this.localStatus){ | ||
| throw new IOException("localStatus is not initialize on construct"); |
Contributor
There was a problem hiding this comment.
Do you want to add name of file to this message if available?
Spacing.
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Author
|
TestStoreFileInfo class throw FileNotFoundException is right ? I see comment like this "Test file link exception" there . |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
I think this is an useful improvement. Seems the UT failures are related? Any progress here? Thanks. |
Author
|
@Apache9 TestStoreFileInfo.java need to change a little after i put localstatus to construct . I will modify TestStoreFileInfo soon . |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
binlijin
reviewed
Apr 29, 2020
| status = link.getFileStatus(fs); | ||
| } catch (FileNotFoundException ex) { | ||
| // try the other location | ||
| throw ex; |
Contributor
There was a problem hiding this comment.
just throw ex it will have no chance to try the other location, see the old code, it should keep the behave with old code.
| } else { | ||
| throw new IOException("path=" + p + " doesn't look like a valid StoreFile"); | ||
| } | ||
| if(this.localStatus == null){ |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Author
|
How can i reslove the UT failure "Failed to read test report file ..." ? |
Contributor
|
@HuiHang-Yu Those kind of failures are often the test crashing out not writing the xml report properly... Its a while since this PR ran. Try a new push to trip the UTs again? |
Contributor
|
Closing. Replacing w/ refresh #3596 |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
Actually close |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I close the PR #958 for mistaking push too many commits after correcting my code serveral times .