HBASE-23686 Revert binary incompatible change in ByteRangeUtils and removed reflections in CommonFSUtils#1036
Merged
HorizonNet merged 3 commits intoapache:masterfrom Jan 19, 2020
Merged
Conversation
…emoved reflections in CommonFSUtils
busbey
requested changes
Jan 14, 2020
| "local filesystem implementation doesn't support storage policies.", exception); | ||
| } | ||
| // check for lack of HDFS-7228 | ||
| if (e instanceof InvocationTargetException) { |
Contributor
There was a problem hiding this comment.
This should be two direct checks for RemoteException and UnsupportedOperationException respectively. Now that we're not using reflection it won't be wrapped in InvocationTargetException
Contributor
Author
There was a problem hiding this comment.
Removed the outer check for the InvocationTargetException.
This comment has been minimized.
This comment has been minimized.
|
🎊 +1 overall
This message was automatically generated. |
busbey
approved these changes
Jan 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the feedback from Sean on #1034.