Conversation
pjfanning
commented
Jul 6, 2025
| @@ -1,13 +1,201 @@ | |||
| Copyright (c) 2025-present Apache Software Foundation | |||
Member
Author
There was a problem hiding this comment.
the copyright is in the notice file
skrawcz
reviewed
Jul 6, 2025
| same "printed page" as the copyright notice for easier | ||
| identification within third-party archives. | ||
|
|
||
| Copyright [yyyy] [name of copyright owner] |
Contributor
There was a problem hiding this comment.
Suggested change
| Copyright [yyyy] [name of copyright owner] | |
| Copyright 2025 Apache Software Foundation |
Member
Author
There was a problem hiding this comment.
we do not set this - please look at ASF projects and see we never set this - it is in the notice file
Member
Author
There was a problem hiding this comment.
If you read the license - this is in the Appendix and is documentation not a copyright stmt.
Contributor
There was a problem hiding this comment.
Really? Did legal review that? It seems like the license is applied incorrectly otherwise -- but sure there would be duplication then.
Contributor
There was a problem hiding this comment.
Or it should say see NOTICE file ... or something...
skrawcz
approved these changes
Jul 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is the correct license