Bumps version from 1.85.1 to 1.86.0#1265
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to d670b4e in 10 seconds
More details
- Looked at
25lines of code in3files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. pyproject.toml:60
- Draft comment:
Ensure that the new 'furo' version is compatible with the rest of the dependencies and the project requirements, as it was previously pinned to a specific GitHub branch. - Reason this comment was not posted:
Confidence changes required:50%
The change from a specific GitHub branch to a package version for 'furo' should be verified for compatibility.
2. pyproject.toml:60
- Draft comment:
Consider adding documentation underdocs/to explain the change in thefurodependency from a specific git commit to a versioned release. This will help users understand the change in dependency management. - Reason this comment was not posted:
Confidence changes required:50%
The PR is a version bump, which is straightforward. However, the change in thepyproject.tomlfile regarding thefurodependency should be documented.
Workflow ID: wflow_VmSN7m6jmelduoLu
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
d670b4e to
4e90daf
Compare
4e90daf to
7ec522a
Compare
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 4e90daf in 2 seconds
More details
- Looked at
7lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. hamilton/version.py:1
- Draft comment:
Version bump is correct and follows semantic versioning. No issues found. - Reason this comment was not posted:
Confidence changes required:0%
The version bump is correct and follows semantic versioning. No issues found.
2. hamilton/version.py:1
- Draft comment:
This version bump is appropriate and doesn't violate any of the specified rules. No changes are needed. - Reason this comment was not posted:
Confidence changes required:0%
The PR is a simple version bump, which is appropriate and doesn't violate any of the specified rules. No changes are needed.
Workflow ID: wflow_zs49A39J6PHewktq
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 7ec522a in 2 seconds
More details
- Looked at
7lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. hamilton/version.py:1
- Draft comment:
Version bump is correct and aligns with the PR description. No issues found. - Reason this comment was not posted:
Confidence changes required:0%
The version bump is correct and aligns with the PR description. No issues found.
2. hamilton/version.py:1
- Draft comment:
No issues found with the version bump. - Reason this comment was not posted:
Confidence changes required:0%
The version bump is straightforward and doesn't violate any of the specified rules. No further comments are necessary.
Workflow ID: wflow_C50KWNE2jU1W1oWC
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version bump