Updates first dataflow docs#1245
Merged
Merged
Conversation
They weren't up to date. Also added note about disabling plugins.
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 9f6a239 in 5 seconds
More details
- Looked at
54lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. docs/get-started/your-first-dataflow.rst:109
- Draft comment:
Consider providing a complete example fordr.visualize_executionor remove the comment if not intended for use. - Reason this comment was not posted:
Confidence changes required:50%
The comment on line 109 suggests using a PNG file for visualization, but the code is commented out. It would be more helpful to provide a complete example or remove the comment if it's not intended to be used.
2. docs/get-started/your-first-dataflow.rst:133
- Draft comment:
Consider adding this note about disabling autoloading of extensions to the Sphinx documentation underdocs/how-tos/extensions-autoloading.rstfor better visibility and reference. - Reason this comment was not posted:
Confidence changes required:50%
The note about disabling autoloading of extensions is useful and should be documented in the appropriate section for future reference.
Workflow ID: wflow_YGIAClWhmRvWeiSM
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They weren't up to date. Also added note about disabling plugins.
Changes
How I tested this
Notes
Checklist