Fixes #1240

[skrawcz]

The cache store assumed that every persister took a path argument. That is not the case because the savers / loaders wrap external APIs and we decided to not try to create our own abstraction layer around them, and instead mirror them.

E.g. polars takes file, but pandas takes path.

Changes

• cache/store.py

How I tested this

• locally

Notes

Checklist

• PR has an informative and human-readable title (this will be pulled into the release notes)
• Changes are limited to a single goal (no scope creep)
• Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
• Any change in functionality is tested
• New functions are documented (with a description, list of inputs, and expected output)
• Placeholder code is flagged / future TODOs are captured in comments
• Project documentation has been updated if adding/changing functionality.

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to 2e46872 in 31 seconds

More details

• Looked at 36 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. hamilton/caching/stores/file.py:80

• Draft comment:
  Ensure that saver_cls.name() and loader_cls.name() are valid method calls. If these classes do not have a name() method, consider using saver_cls.__name__ and loader_cls.__name__ to get the class name.
• Reason this comment was not posted:
  Comment did not seem useful.

Workflow ID: wflow_9zJcc6qIk9G7I0QK

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

❌ Changes requested. Incremental review on e12b943 in 40 seconds

More details

• Looked at 127 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. tests/caching/test_result_store.py:196

• Draft comment:
  Using eval to load data is a security risk. Consider using a safer alternative like json.loads or ast.literal_eval if the data format allows.
• Reason this comment was not posted:
  Marked as duplicate.

2. tests/caching/test_result_store.py:145

• Draft comment:
  Avoid using eval for loading data as it can execute arbitrary code. Consider using a safer alternative like json.loads if the data format allows.
• Reason this comment was not posted:
  Marked as duplicate.

Workflow ID: wflow_ZHnp8LhCA8wQPFRN

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

Using eval to load data is a security risk. Consider using a safer alternative like json.loads or ast.literal_eval if the data format allows.

Suggested change

	data = eval(f.read())
	data = ast.literal_eval(f.read())